Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove filtering parameters from GetExtents. #179

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Remove filtering parameters from GetExtents. #179

merged 1 commit into from
Sep 20, 2024

Conversation

lukas-phaf
Copy link
Contributor

@lukas-phaf lukas-phaf commented Sep 19, 2024 •
edited
Loading

Also add index for observation time.

Note that the bounding box will be incorrect after this change (as it is now just based on the geo_point table), until we set up the geo_point table.

@github-actions GitHub Actions
Copy link

API Unit Test Coverage Report
FileStmtsMissCoverMissing
\_\_init\_\_.py00100% 
datastore_pb2.py614821%34–81
datastore_pb2_grpc.py542750%15–16, 19, 57–72, 105–107, 112–114, 119–121, 126–128, 132–157, 195, 222, 249, 276
export_metrics.py100100% 
grpc_getter.py201145%15–19, 23–26, 30–32, 36–38
locustfile.py15150%1–31
main.py43784%45, 50, 60, 70–71, 81–82
metadata_endpoints.py632954%45–54, 58, 85, 100–216, 220
response_classes.py50100% 
utilities.py1815669%20, 38, 45, 67–70, 78–89, 94–101, 121, 125, 127, 154, 157, 166, 184–185, 189, 205–210, 215, 219–220, 224–226, 232–240, 250–253, 259–260, 272–276, 299, 304, 317
custom_geo_json
   edr_feature_collection.py60100% 
formatters
   \_\_init\_\_.py110100% 
   covjson.py57198%88
   geojson.py17288%21, 46
openapi
   custom_dimension_examples.py40100% 
   edr_query_parameter_descriptions.py110100% 
   openapi_examples.py130100% 
routers
   \_\_init\_\_.py00100% 
   edr.py102496%350–351, 441–442
   feature.py471960%99–132, 148–153, 159–181
TOTAL72021970% 

API Unit Test Coverage Summary

Tests Skipped Failures Errors Time
30 0 💤 0 ❌ 0 🔥 1.946s ⏱️

jo-asplin-met-no
jo-asplin-met-no approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@jo-asplin-met-no jo-asplin-met-no left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jo-asplin-met-no jo-asplin-met-no merged commit b731890 into main Sep 20, 2024
8 checks passed
@jo-asplin-met-no jo-asplin-met-no deleted the extent-performance branch September 20, 2024 09:20
@Teddy-1000 Teddy-1000 restored the extent-performance branch October 2, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jo-asplin-met-no jo-asplin-met-no jo-asplin-met-no approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukas-phaf @jo-asplin-met-no